This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Move InterfaceDispatchMapTable to data section #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkotas PTAL |
|
Addresses issue #667 |
|
It is unnecessary inefficiency to put this into data section on Windows. We should make it go to "rdata" section on Windows, and "data" everywhere else. Could you please make the same change for all |
Linking on Mac generates a warning that InterfaceDispatchMapTable disables PIE (Unix's version of ASLR). Placing the table in the rdata section caused pointers across to the data section where the maps live. Move EETypes and related nodes, plus read-only interface dispatch data structures in the rdata section on Windows.
|
@jkotas Updated to move EETypeNode, EETypeOptionalFieldsNode, GCStaticEETypeNode, InterfaceDispatchMapNode, and InterfaceDispatchMapTableNode to rdata on Windows. |
|
LGTM |
jkotas
added a commit
that referenced
this pull request
Jan 21, 2016
Move InterfaceDispatchMapTable to data section
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking on Mac generates a warning that InterfaceDispatchMapTable disables PIE (Unix's version of ASLR). Placing the table in the rdata section caused pointers across to the data section where the maps live.