Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-org build step #648

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Remove cross-org build step #648

merged 4 commits into from
Nov 3, 2023

Conversation

sebastienros
Copy link
Member

Matching PR: dotnet/arcade#11577

@sebastienros sebastienros requested a review from chcosta October 19, 2023 22:31
@sebastienros sebastienros changed the title Remove cross-post build step Remove cross-org build step Oct 19, 2023
@sebastienros
Copy link
Member Author

Signing validation doesn't work anymore with this step since the variable group was removed

@@ -1,8 +1,4 @@
variables:
- group: AzureDevOps-Artifact-Feeds-Pats
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An arcade update re-added, this is wrong

@sebastienros sebastienros enabled auto-merge (squash) November 3, 2023 17:51
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update publish-build-assets.yml too? Should this repo get arcade updates automatically?

@sebastienros
Copy link
Member Author

Should this repo get arcade updates automatically?

It does, and that's the issue. It syncs with release/7.0 which still has these variables defined, but they are removed from ADO. So the build would fail. I had removed it before but then a sync added it back and I didn't pay attention.

@sebastienros sebastienros merged commit 1d0bf34 into main Nov 3, 2023
3 of 4 checks passed
@sebastienros sebastienros deleted the sebros/crosspost branch November 3, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants