HttpClient: Fixed LatencyMeanMs not calculating properly #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure of the load test
| @@ -375,7 +375,7 @@ IEnumerable<Task> CreateTasks() | |||
| Started = startTime.ToLocalTime(), | |||
| ThroughputBps = workerTasks.Select(x => x.Result.ThroughputBps).Sum(), | |||
| LatencyMaxMs = Math.Round(workerTasks.Select(x => x.Result.LatencyMaxMs).Max(), 3), | |||
| LatencyMeanMs = workerTasks.Select(x => x.Result.TotalRequests).Sum() == 0 ? 0 : Math.Round((stopTime - startTime).TotalMilliseconds / workerTasks.Select(x => x.Result.TotalRequests).Sum(), 3), | |||
| LatencyMeanMs = Math.Round(workerTasks.Select(x => x.Result.LatencyMeanMs).Average(), 3), | |||
There was a problem hiding this comment.
This is assuming that each worker sends the same amount of requests, but we can do that. Meaning that if a worker was sending a single request that is 1ms, and another worker was sending 1000 requests of 1s avg, then it would result in an average of 500ms while it closer to 1s. Whatever, this is closer to reality now.
The only correct option would be to store the TotalLatency and TotalRequests per worker and then do the mean of all these.
There was a problem hiding this comment.
ah yes, you are correct. In reality we want the sum of TotalLatency of all workers divided by the sum of TotalRequests of all workers.
Change has been done :)
sebastienros
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LatencyMeanMs is not taking into consideration the parallelism nature of the load test.
The calculation is currently done by taking the whole time it took to run the test and divide it by the number of requests which implies that the requests were done sequentially