New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the Startup Event to the Benchmarks Event Source #696

Merged

sebastienros merged 2 commits into dotnet:main from mrsharm:StartupEvent

Feb 7, 2024

Member

mrsharm commented Feb 7, 2024

Related to: aspnet/Benchmarks#1862 (comment)

Added the startup event as a part of the Benchmarks event source.
Tested with the hello scenario using the following command: crank --config /crank/samples/local/local.benchmarks.yml --scenario hello --profile local --application.collect true --application.collectArguments "Providers=Benchmarks"
Observed the event showing up in the Events View in PerfView:

Please let me know if there is a better way to accomplish this.

mrsharm added 2 commits

February 7, 2024 11:12


          Working solution to emit the Startup Event

38d9260


          Removed redundant changed code

1c4cce6

mrsharm requested a review from sebastienros

February 7, 2024 19:17

sebastienros approved these changes

View reviewed changes

sebastienros merged commit 0ead447 into dotnet:main

4 checks passed

Member

sebastienros commented Feb 7, 2024

Will be deployed automatically tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet