C# colorization of inline function is not quite right

[aeschli]

From @TwitchBronBron on May 23, 2018 10:44

Issue Type: Bug

There is some inconsistent behavior with the colorization of c# parameters inside of inline functions. See this screenshot:

Source code

namespace TestNamespace {
    public class TestClass
    {
        public TestClass(
        )
        {
            //the parameters have weird coloring at the end
            CallMeBack((param, paramWithNumbers12345, param678WitLettersAtEnd)=>{

            });
            
            //these parameters aren't colored at all
            CallMeBack((
                param1, 
                paramWithNumbers12345, 
                param678WitLettersAtEnd
            )=>{

            });
        }
    }
}

VS Code version: Code - Insiders 1.24.0-insider (a521c01d56ec7f07bea2471880f28a77f37983af, 2018-05-21T05:18:01.058Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-3720QM CPU @ 2.60GHz (8 x 2591)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: unavailable_software webgl: enabled webgl2: enabled
Memory (System)	7.90GB (1.99GB free)
Process Argv	C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
ng-template	Ang	0.1.9
tslint	eg2	1.0.29
php-intellisense	fel	2.3.1
vscode-mysql	for	0.3.0
docomment	k--	0.1.0
code-beautifier	mic	2.0.3
csharp	ms-	1.15.2

Copied from original issue: microsoft/vscode#50339

[DustinCampbell]

This looks very similar to #119.

[DustinCampbell]

@aeschli: we've just gotten two bugs about this problem (#119 and #120) and both are reported on VS Code Insiders 1.24.0. I just tried and could not reproduce the problem in VS Code 1.23.1 but I could reproduce it in VS Code Insiders 1.24.0. So, this looks like a VS Code regression. Do you see the same behavior?

[DustinCampbell]

I think I figured out where the regression is on the drive in to work this morning. If I'm right, I should have a fix soon.