Proposal to add Framework specific inbox source generators #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document describes desired characteristics for source generators we wish to add to .NET 6.0.
ericstj
requested review from
davidfowl,
dsplaisted,
jaredpar,
pranavkm,
marek-safar,
captainsafia,
stephentoub,
terrajobst,
KathleenDollard,
maryamariyan,
eerhardt,
layomia and
chsienki
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
jkotas
reviewed
Feb 23, 2021
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
marek-safar
reviewed
Feb 23, 2021
dsplaisted
reviewed
Feb 23, 2021
|
@elinor-fung I addressed most of your feedback, care to have another look? |
|
Looks good. Thanks for clarifying/removing the side-by-side terminology - definitely helpful for me. |
jeffhandley
approved these changes
Mar 26, 2021
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
jaredpar
reviewed
Mar 28, 2021
Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>
5 tasks
…tors And fix typos.
RussKie
reviewed
May 27, 2021
|
@RussKie could you share briefly what source generators the Winforms team is creating this cycle? Just curious for those not aware. |
|
Here're the details #223 |
RussKie
added a commit
to dotnet/wpf
that referenced
this pull request
Jun 2, 2021
Provide a mechanism to ingest Windows Forms specific analyzer props and targets into Microsoft.NET.Sdk.WindowsDesktop from Windows Forms transport package, and copy these files into `targets` folder of the SDK, so that the props files are resolved and imported when a developer builds a Windows Forms app. In the end the new props file will end up in a location similar to this: `C:\Program Files\dotnet\sdk\6.0.<version>\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\`. This work relates to dotnet/designs#223, and acts as a workaround until dotnet/designs#181 is approved and implemented.
RussKie
added a commit
to dotnet/windowsdesktop
that referenced
this pull request
Jun 2, 2021
Provide a mechanism to import Windows Forms specific analyzers from Windows Forms transport package, and and package those into Microsoft.WindowsDesktop.App.Ref bundle, so that they are available in Windows Forms app out of the box. The analyzers are referenced via props and targets located in `C:\Program Files\dotnet\sdk\6.0.<version>\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\`, which is facilitated by dotnet/wpf#4605. This work relates to dotnet/designs#223, and acts as a workaround until dotnet/designs#181 is approved and implemented.
RussKie
added a commit
to dotnet/wpf
that referenced
this pull request
Jun 7, 2021
Provide a mechanism to ingest Windows Forms specific analyzer props and targets into Microsoft.NET.Sdk.WindowsDesktop from Windows Forms transport package, and copy these files into `targets` folder of the SDK, so that the props files are resolved and imported when a developer builds a Windows Forms app. In the end the new props file will end up in a location similar to this: `C:\Program Files\dotnet\sdk\6.0.<version>\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\`. This work relates to dotnet/designs#223, and acts as a workaround until dotnet/designs#181 is approved and implemented.
|
@ericstj should this be merged now? |
Nearly. I think I have POR now that we want to do this. I want to take one last read through and make sure I don't need to update some of the details. Expect to merge by end of week. |
|
I haven't forgotten about this, just had less time than I thought last week due to a family visit / time off. I'll move this forward shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes desired characteristics for source generators we
wish to add to .NET 6.0.