Skip to content

Commit

Permalink
Remove Windows arm32 support (#5081)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikem8361 authored Dec 4, 2024
1 parent 5f957db commit d12018b
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 34 deletions.
3 changes: 0 additions & 3 deletions diagnostics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ extends:
architecture: x86
artifactUploadPath: bin/Windows_NT.x86.Release
- ${{ if ne(variables['System.TeamProject'], 'public') }}:
- configuration: Release
architecture: arm
artifactUploadPath: bin/Windows_NT.arm.Release
- configuration: Release
architecture: arm64
artifactUploadPath: bin/Windows_NT.arm64.Release
Expand Down
16 changes: 8 additions & 8 deletions eng/release/tool-list.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,35 @@
"AssetList": [
{
"name": "dotnet-counters",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-dump",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-gcdump",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-sos",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-trace",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-stack",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-dsrouter",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
},
{
"name": "dotnet-symbol",
"rids": ["win-x64", "win-x86", "win-arm", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
"rids": ["win-x64", "win-x86", "win-arm64", "linux-x64", "linux-musl-arm64", "osx-x64", "linux-arm64", "linux-musl-x64", "linux-arm"]
}
]
},
Expand Down
1 change: 0 additions & 1 deletion src/SOS/SOS.Package/SOS.Package.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
<Files>
<File Architecture="amd64" Module="win-x64\sos.dll" />
<File Architecture="x86" Module="win-x86\sos.dll" />
<File Architecture="arm32" Module="win-arm\sos.dll" />
<File Architecture="arm64" Module="win-arm64\sos.dll" />
</Files>
<LoadTriggers>
Expand Down
3 changes: 0 additions & 3 deletions src/SOS/SOS.Package/SOS.Symbol.Package.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
<None Include="$(ArtifactsBinDir)\Windows_NT.x86.$(Configuration)\PDB\sos.pdb" Pack="true" Visible="false">
<PackagePath>$(SOSPackagePathPrefix)/win-x86</PackagePath>
</None>
<None Include="$(ArtifactsBinDir)\Windows_NT.arm.$(Configuration)\PDB\sos.pdb" Pack="true" Visible="false">
<PackagePath>$(SOSPackagePathPrefix)/win-arm</PackagePath>
</None>
<None Include="$(ArtifactsBinDir)\Windows_NT.arm64.$(Configuration)\PDB\sos.pdb" Pack="true" Visible="false">
<PackagePath>$(SOSPackagePathPrefix)/win-arm64</PackagePath>
</None>
Expand Down
4 changes: 2 additions & 2 deletions src/Tools/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
<PropertyGroup>
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86;win-arm;osx-x64</PackAsToolShimRuntimeIdentifiers>
<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86;osx-x64</PackAsToolShimRuntimeIdentifiers>
<PackagedShimOutputRootDirectory>$(OutputPath)</PackagedShimOutputRootDirectory>
</PropertyGroup>
</Otherwise>
</Choose>
</Project>
</Project>
3 changes: 1 addition & 2 deletions src/dbgshim/dbgshim.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@
<None Include="pkg\Microsoft.Diagnostics.DbgShim.osx-x64.proj" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.proj" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.props" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-arm.proj" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-arm64.proj" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-x64.proj" />
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-x86.proj" />
Expand All @@ -393,4 +392,4 @@
<ImportGroup Label="ExtensionTargets">
<Import Project="$(VCTargetsPath)\BuildCustomizations\masm.targets" />
</ImportGroup>
</Project>
</Project>
5 changes: 1 addition & 4 deletions src/dbgshim/dbgshim.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
<None Include="pkg\Microsoft.Diagnostics.DbgShim.props">
<Filter>pkg</Filter>
</None>
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-arm.proj">
<Filter>pkg</Filter>
</None>
<None Include="pkg\Microsoft.Diagnostics.DbgShim.win-arm64.proj">
<Filter>pkg</Filter>
</None>
Expand All @@ -63,4 +60,4 @@
<ClInclude Include="debugshim.h" />
<ClInclude Include="dbgshim.h" />
</ItemGroup>
</Project>
</Project>
7 changes: 0 additions & 7 deletions src/dbgshim/pkg/Microsoft.Diagnostics.DbgShim.win-arm.proj

This file was deleted.

2 changes: 1 addition & 1 deletion src/singlefile-tools.proj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFramework>$(NetCoreAppMinTargetFramework)</TargetFramework>
<SupportedRids>win-x64;win-x86;win-arm;win-arm64;linux-x64;linux-musl-arm64;linux-arm64;linux-musl-x64;linux-arm</SupportedRids>
<SupportedRids>win-x64;win-x86;win-arm64;linux-x64;linux-musl-arm64;linux-arm64;linux-musl-x64;linux-arm</SupportedRids>
<ArcadeSdkMSBuildProjectDir>$([System.IO.Path]::GetDirectoryName('$(ArcadeSdkBuildTasksAssembly)'))\..\</ArcadeSdkMSBuildProjectDir>
<ArcadeSdkSignProject>$(ArcadeSdkMSBuildProjectDir)Sign.proj</ArcadeSdkSignProject>
<BundledToolsZipDirectory>$(BundledToolsPath)$(Configuration)/zips/</BundledToolsZipDirectory>
Expand Down
3 changes: 0 additions & 3 deletions src/sos-packaging.props
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.x86.$(Configuration)\sos.dll" TargetRid="win-x86" />
<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.x86.$(Configuration)\Microsoft.DiaSymReader.Native.x86.dll" TargetRid="win-x86" />

<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.arm.$(Configuration)\sos.dll" TargetRid="win-arm" />
<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.arm.$(Configuration)\Microsoft.DiaSymReader.Native.arm.dll" TargetRid="win-arm" />

<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.arm64.$(Configuration)\sos.dll" TargetRid="win-arm64" />
<SosRequiredBinaries Include="$(ArtifactsBinDir)\Windows_NT.arm64.$(Configuration)\Microsoft.DiaSymReader.Native.arm64.dll" TargetRid="win-arm64" />

Expand Down

0 comments on commit d12018b

Please sign in to comment.