Add IMAGE_FILE_MACHINE_ARM64X and IMAGE_FILE_MACHINE_ARM64EC

[hoyosjs]

Co-authored-by: David Mason davmason@microsoft.com

[davmason]

You can also get IMAGE_FILE_MACHINE_ARM64X and IMAGE_FILE_MACHINE_ARM64EC when you are debugging in x64 emulation on arm64 machines. For a complete fix you should add logic so when you are in SOS_TARGET_X64 and you see either of them then load the x64 machine

[hoyosjs]

Then this is not going to work - if we can get such value in both arm64 and x64 scenarios we might need something different to identify process arch.

[mikem8361]

I think it will work. If SOS is running on x64 (either real or emulated), both SOS_TARGET_AMD64 and SOS_TARGET_ARM64 are defined so putting the checks for those two processor types in the SOS_TARGET_ARM64 section should work.

[mikem8361]

Should work the way Juan has it now.

[hoyosjs]

ArchQuery/GetTargetMachine should return the target's process instruction architecture/machine (regardless of SOS's host). Right now it will return the ARM64 IMachine. I think David had mentioned there are cases where this value can be returned on x64 processes on arm64 machines. If that's true, this patch is incomplete. Otherwise, this fix seems fine as we define both targets for the x64 SOS.

[noahfalk]

I am closing old PRs that have had no progress in a long time. You are welcome to resume the work any time and open a new PR.

[mikem8361]

@hoyosjs can you review?

The changes requested have been fixed.

[hoyosjs]

LGTM modulo the thing.