Add Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unify counters * fixup merge * Switched to using AggregatePercentilePayload. * Changes to AggregatePercentilePayload * Bug fixes to improve consistency with existing dotnet counters tool * Adjustments to support shared sessions - this has not been tested. * Bug fix. * Clean up before PR * Small adjustments. * Small changes. * Fixes small filtering bug with instrumentation started * Reintroduced display name for aggregate percentile payload * Partial PR Feedback - has not been tested, and needs more changes. * More PR Feedback. * PR Feedback. * End to end appears to be working, need to add testing and do cleanup. Note that this operates under the assumption of unique meter names * Small cleanup, condensing tests. --------- Co-authored-by: wiktork <wiktork@microsoft.com>
noahfalk
reviewed
Oct 20, 2023
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Nov 17, 2023
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/CachedCounterInfo.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Nov 17, 2023
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Nov 17, 2023
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
…or providers/counters
jander-msft
approved these changes
Dec 4, 2023
|
From what I can see, this broke the build. @kkeirstead CI didn't ran since Dec 4th which is why you didn't see the failures in the PR. |
ViktorHofer
added a commit
to ViktorHofer/diagnostics
that referenced
this pull request
Jan 8, 2024
…tics Metrics (dotnet#4324)" This reverts commit e701ba5.
Thanks for the heads-up, this PR was sitting for a while so that would make sense. I'll start working on a fix now, it looks like it's from the recent changes in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes along with kkeirstead/dotnet-monitor#237 in the dotnet-monitor repo.
This PR adds meter tags, instrument tags, and scopes to System Diagnostics Metrics. There is currently a limitation (see dotnet/runtime#93097) around having multiple providers with the same name. As a result, this PR currently makes the assumption that all meters have unique names.
Just a quick note - I made some guesses about how this data should be displayed/formatted, but I can change this if this information should be presented differently (or not at all for dotnet-counters).