Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symbolGenerator to raise diagnostic identity key level #4924

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Use symbolGenerator to raise diagnostic identity key level #4924

merged 1 commit into from
Sep 12, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Sep 12, 2024

No description provided.

@hoyosjs hoyosjs requested a review from a team as a code owner September 12, 2024 03:24
mdh1418
mdh1418 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just for the special diagnostics files themselves to not be overwritten?
If so, looks good to me

@hoyosjs
Copy link
Member Author

hoyosjs commented Sep 12, 2024

So this is just for the special diagnostics files themselves to not be overwritten?

Yes, there's plenty of scenarios where we do lookup by identity key

@hoyosjs hoyosjs merged commit 3007744 into dotnet:main Sep 12, 2024
20 checks passed
@hoyosjs hoyosjs deleted the dev/juhoyosa/symgenerator-bump branch September 12, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommcdon tommcdon tommcdon approved these changes

@mdh1418 mdh1418 mdh1418 approved these changes

@mikem8361 mikem8361 Awaiting requested review from mikem8361

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoyosjs @tommcdon @mdh1418