TargetFramework support

[paulushub]

Does this really work? I have tried both .net7.0 and net7.0-windows without success.
The project includes .NET 6~8 targets support.

      "src": [
        {
          "files": [
            "SVGImage/DotNetProjects.SVGImage.csproj"
          ],
          "src": "../Source/",
          "properties": {
            "TargetFramework": "net7.0-windows"
          }          
        }
      ],

GitHub workflow:

# Your GitHub workflow file under .github/workflows/
name: DocFX

on:
  push:
    branches:
      - master
      
jobs:
  publish-docs:
    runs-on: windows-latest
    steps:
    - name: Checkout
      uses: actions/checkout@v3
    - name: Dotnet Setup
      uses: actions/setup-dotnet@v3
      with:
        dotnet-version: 7.x

    - run: dotnet tool update -g docfx
    - run: docfx Docs/docfx.json

    - name: Upload DocFX packages
      uses: actions/upload-artifact@v3
      with:
        name: docfx_site
        path: ${{ github.workspace }}/Docs/_site
          
    - name: Deploy
      uses: peaceiris/actions-gh-pages@v3
      with:
        github_token: ${{ secrets.GITHUB_TOKEN }}
        publish_dir: Docs/_site

[KalleOlaviNiemitalo]

IIRC NuGet package restore uses all TargetFrameworks, not only TargetFramework. Then your pipeline has dotnet-version: 7.x which doesn't support targeting .NET 8.

But I wonder if you could work around that by setting both TargetFrameworks and TargetFramework in DocFX.

[paulushub]

Setting the pipeline has dotnet-version: 8.x resolved it. Thank you.

[filzrev]

NuGet package restore uses all TargetFrameworks, not only TargetFramework.

As far as I've tested.
dotnet restore problems can be fixed by modifying following lines

docfx/src/Docfx.Dotnet/DotnetApiCatalog.Compile.cs

Line 132 in be96e63

await Process.Start("dotnet", $"restore \"{path}\"").WaitForExitAsync();

Modified Code
When TargetFramework parameter specified. Pass parameter to dotnet restore command.

if (msbuildProperties.TryGetValue("TargetFramework", out var targetFramework))
{
    await Process.Start("dotnet", $"restore \"{path}\" -p:TargetFramework={targetFramework} --locked-mode").WaitForExitAsync();
}
else
{
    await Process.Start("dotnet", $"restore \"{path}\"").WaitForExitAsync();
}

Note
--locked-mode settings is required to disable overwrite packages.lock.json file.
It's required when target project using <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> settings.

Without --locked-mode parameter. packages.lock.json is overwritten for specified target framework.
And cause file diff when executing docfx metadata command)