Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yml for potential security issue. #10242

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Update ci.yml for potential security issue. #10242

merged 1 commit into from
Oct 1, 2024

Conversation

markjulmar
Copy link
Contributor

Replace pull_request_target with pull_request to mitigate potential vulnerability.

@markjulmar
Update ci.yml
afc8d36 
Replace pull_request_target with pull_request to mitigate potential vunerability.
yufeih
yufeih approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break percy visual regression testing for PRs from forked repo, but yes lets update the security problem first.

@yufeih yufeih merged commit f99e02c into dotnet:main Oct 1, 2024
11 checks passed
@filzrev filzrev mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markjulmar @yufeih