Provide option for msbuild properties #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vwxyzh
reviewed
Apr 14, 2017
| @@ -38,7 +38,7 @@ public BuildInfo GetValidConfig(IEnumerable<string> inputProjects) | |||
| return GetConfig(key); | |||
| } | |||
|
|
|||
| public void SaveToCache(IEnumerable<string> inputProjects, IDictionary<string, List<string>> containedFiles, DateTime triggeredTime, string outputFolder, IList<string> fileRelativePaths, bool shouldSkipMarkup) | |||
| public void SaveToCache(IEnumerable<string> inputProjects, IDictionary<string, List<string>> containedFiles, DateTime triggeredTime, string outputFolder, IList<string> fileRelativePaths, bool shouldSkipMarkup, IDictionary<string, string> msbuildProperties) | |||
There was a problem hiding this comment.
create a class for parameters?
There was a problem hiding this comment.
will do refactor later
|
|
vicancy
added a commit
that referenced
this pull request
Apr 14, 2017
* Provide option for msbuild properties * Update RELEASENOTE.md
20 tasks
|
Does this Issue perchance cover preprocessor symbol handling as suggested in #1518?
We have some APIs that are only generated for certain builds where certain Preprocessor Symbols are defined. It would be awesome if the same symbols specified when building assemblies could similarly affect the generated documentation (i.e. make generated documentation content match the generated code content)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1518 & #1254