Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using separator in code constants #543

Closed
wants to merge 1 commit into from
Closed

Using separator in code constants #543

wants to merge 1 commit into from

Conversation

peterennis
Copy link
Contributor

Correction for typos in constant names. NOTE: lunr - http://lunrjs.com -
A bit like Solr, but much smaller and not as bright - 0.6.0
This project has the same problem but it is not touched in the PR.

Correction for typos in constant names. NOTE: lunr - http://lunrjs.com -
A bit like Solr, but much smaller and not as bright - 0.6.0
This project has the same problem but it is not touched in the PR.
@peterennis
Copy link
Contributor Author

PR opened with lunr to fix their source.
olivernn/lunr.js@d953667

@qinezh
Copy link
Contributor

qinezh commented Aug 2, 2016

The angular template is deprecated now, please do not modify it.

@peterennis
Copy link
Contributor Author

OK. I will pull new code at the next release. Is lunr being removed?

@qinezh
Copy link
Contributor

qinezh commented Aug 2, 2016

No, lunr.js is used for full text search and won't be removed.

@peterennis
Copy link
Contributor Author

Closed as deprecated.

@peterennis peterennis closed this Aug 4, 2016
@peterennis
Copy link
Contributor Author

lunr.js
olivernn/lunr.js#223 (comment)
separator should be resolved with 0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants