chore: Remove NuGet.Frameworks dependency from test projects
#9276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9276 +/- ##
==========================================
+ Coverage 71.38% 71.39% +0.01%
==========================================
Files 561 561
Lines 23961 23961
Branches 4163 4163
==========================================
+ Hits 17105 17108 +3
+ Misses 5762 5759 -3
Partials 1094 1094 ☔ View full report in Codecov by Sentry. |
yufeih
force-pushed
the
main
branch
2 times, most recently
from
8896961
to
750b554
Compare
yufeih
approved these changes
Nov 16, 2023
|
Merge this to avoid dependabot using private NuGet feed. It's OK to use preview releases just for tests. |
yufeih
added
the
engineering
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
…t#9276) * chore: fix NuGet.Frameworks package version * chore: remove NuGet.Frameworks dependency from test projects * chore: update test sdk version * chore: remove NuGet.config file that is used for NuGet.Frameworks --------- Co-authored-by: Yufei Huang <yufeih@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR is intended to execute CI tests.
It'll be merged to main branch when
Microsoft.NET.Test.Sdkv17.9is released.What's included in this PR
Microsoft.NET.Test.Sdkpackage to17.9.0(preview)NuGet.Frameworksreference from test projectsBackground
Latest vstest packages (v17.9) remove dependency on Nuget.Frameworks
So
NuGet.Frameworkspackage will not be needed in the future.Note:
v17.9seems to be released onFeb '24.