Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove template file copy verbose logs #9409

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 9, 2023

What's included in this PR

  • Remove template file copy logs (skipped or saved)

Background
When running docfx build command with --logLevel Verbose.
Too much logs are written relating to template files copy.

Example:

Skipped resource public/docfx.min.css that template dependants on to C:\Projects\GitHub\filzrev\docfx\samples\seed_site\public\docfx.min.css
Skipped resource public/docfx.min.css.map that template dependants on to C:\Projects\GitHub\filzrev\docfx\samples\seed_site\public\docfx.min.css.map
Skipped resource public/docfx.min.js that template dependants on to C:\Projects\GitHub\filzrev\docfx\samples\seed_site\public\docfx.min.js

These logs are less important to build document process logging.
And not consistent compared to other file output processing. (e.g. Output HTML files is not logged)
So I've remove these logs in this PR.

I thought these logs should be logged as Debug level. (Currently not supported)
And it can be filtered by category with customizable configurations (By using Microsoft.Extensions.Logging)

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...ocfx.Build/TemplateProcessors/TemplateProcessor.cs 63.95% <ø> (+0.31%) ⬆️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yufeih yufeih merged commit 7b8f375 into dotnet:main Nov 10, 2023
8 checks passed
yufeih pushed a commit that referenced this pull request Nov 13, 2023
chore: remove template file copy verbose logs
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore: remove template file copy verbose logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants