Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the github actions not working properly in the newest versions of docfx with default settings #9430

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

ysftulek
Copy link
Contributor

I have updated the actions script because old version was not working properly in the newest versions of DocFX. It now uses official upload pages actions instead of relying on the third party one. And now the default path is correct for website deployment: 'docfx_project/_site' instead of 'docs/_site'.

I have updated the actions script because old version was not working properly in the newest versions of docfx. It now uses official upload pages actions instead of relying on the third party one. And now the default path is correct for website deployment: 'docfx_project/_site' instead of 'docs/_site'.
@ysftulek
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ysftulek !

@yufeih yufeih added the documentation Improvements or additions to documentation and the project website label Nov 16, 2023
@yufeih yufeih merged commit c2a3a77 into dotnet:main Nov 16, 2023
7 checks passed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation and the project website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants