Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PDF header footer template #9543

Merged
merged 4 commits into from
Dec 20, 2023
Merged

feat: support PDF header footer template #9543

merged 4 commits into from
Dec 20, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 18, 2023

Support custom PDF template using pdfHeaderTemplate and pdfFooterTemplate metadata.

Supports injecting pageNumber and totalPages with HTML classes.

Fixes #9463

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51026a8) 71.36% compared to head (fd80d3e) 71.39%.

Files Patch % Lines
src/Docfx.App/PdfBuilder.cs 97.36% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9543      +/-   ##
==========================================
+ Coverage   71.36%   71.39%   +0.03%     
==========================================
  Files         558      558              
  Lines       24032    24061      +29     
  Branches     4176     4179       +3     
==========================================
+ Hits        17151    17179      +28     
  Misses       5782     5782              
- Partials     1099     1100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Dec 19, 2023
@yufeih yufeih reopened this Dec 19, 2023
@yufeih yufeih closed this Dec 20, 2023
@yufeih yufeih reopened this Dec 20, 2023
@yufeih yufeih marked this pull request as ready for review December 20, 2023 11:31
@yufeih yufeih closed this Dec 20, 2023
@yufeih yufeih reopened this Dec 20, 2023
@yufeih yufeih closed this Dec 20, 2023
@yufeih yufeih reopened this Dec 20, 2023
@yufeih yufeih merged commit 6cb29c4 into main Dec 20, 2023
8 checks passed
@yufeih yufeih deleted the pdftemplate branch December 20, 2023 13:11
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for PDF headers and footers (from html files)
1 participant