Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix filterconfig.yml and enumSortOrder documentation #9839

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Apr 6, 2024

This PR contains following documentation changes.

  • Fix hasAttribute indentation level.
  • Fix Inherited condition string from true to True (It's case sensitive because it's compared by KeyValuePair<string,string>)
  • Fix enumSortOrder document comment.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (fe673ec) to head (40b2461).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9839      +/-   ##
==========================================
+ Coverage   74.31%   78.97%   +4.65%     
==========================================
  Files         536      538       +2     
  Lines       23189    23319     +130     
  Branches     4056     4049       -7     
==========================================
+ Hits        17234    18417    +1183     
+ Misses       4853     3774    -1079     
- Partials     1102     1128      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih added the documentation Improvements or additions to documentation and the project website label Apr 7, 2024
@yufeih yufeih merged commit 6ac8410 into dotnet:main Apr 7, 2024
7 checks passed
@filzrev filzrev deleted the chore-fix-filterconfig-docs branch April 7, 2024 04:25
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation and the project website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants