Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC2 argument name changes #20677

Merged
merged 5 commits into from
Sep 17, 2020
Merged

RC2 argument name changes #20677

merged 5 commits into from
Sep 17, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 17, 2020

Fixes #20501; fixes #20502.

Preview link.

@gewarren gewarren requested a review from a team as a code owner September 17, 2020 01:29
@dotnet-bot dotnet-bot added this to the September 2020 milestone Sep 17, 2020
| <xref:System.StringNormalizationExtensions.IsNormalized(System.String)?displayProperty=nameWithType> | `value` | `strInput` |
| <xref:System.StringNormalizationExtensions.Normalize(System.String,System.Text.NormalizationForm)?displayProperty=nameWithType> | `value` | `strInput` |
| <xref:System.StringNormalizationExtensions.Normalize(System.String)?displayProperty=nameWithType> | `value` | `strInput` |
| <xref:System.Diagnostics.ActivityContext.%23ctor(System.Diagnostics.ActivityTraceId,System.Diagnostics.ActivitySpanId,System.Diagnostics.ActivityTraceFlags,System.String,System.Boolean)> | `traceOptions` | `traceFlags` | .NET 5.0 RC2 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new row in the table.

| <xref:System.StringNormalizationExtensions.Normalize(System.String)?displayProperty=nameWithType> | `value` | `strInput` |
| <xref:System.Diagnostics.ActivityContext.%23ctor(System.Diagnostics.ActivityTraceId,System.Diagnostics.ActivitySpanId,System.Diagnostics.ActivityTraceFlags,System.String,System.Boolean)> | `traceOptions` | `traceFlags` | .NET 5.0 RC2 |
| <xref:System.CodeDom.Compiler.CodeGenerator.GenerateStatements(System.CodeDom.CodeStatementCollection)?displayProperty=nameWithType> | `stms` | `stmts` | .NET 5.0 |
| <xref:System.Globalization.CompareInfo.IsPrefix(System.ReadOnlySpan{System.Char},System.ReadOnlySpan{System.Char},System.Globalization.CompareOptions,System.Int32@)?displayProperty=nameWithType> | `suffix` | `prefix` | .NET 5.0 RC2 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new row in the table.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a question.

The preview link shows these as part of the breaking changes between 3.1 and 5.0. These were only breaking from an earlier 5.0 release as the APIs were introduced in 5.0. It looks like there isn't a page for 5.0 RC1 (or earlier) to RC2. Was it intentional to add them to the 3.1 to 5.0 page since those pages don't exist?

@gewarren
Copy link
Contributor Author

Looks good, but I have a question.

The preview link shows these as part of the breaking changes between 3.1 and 5.0. These were only breaking from an earlier 5.0 release as the APIs were introduced in 5.0. It looks like there isn't a page for 5.0 RC1 (or earlier) to RC2. Was it intentional to add them to the 3.1 to 5.0 page since those pages don't exist?

Yes, that's a valid point. I'll create a separate breaking change entry for these two parameters, then. It will live in the Core .NET libraries breaking changes article file.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 7bef121 into dotnet:master Sep 17, 2020
@gewarren gewarren deleted the args-916 branch September 17, 2020 15:36
@gewarren
Copy link
Contributor Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants