Behavior changes due to NLS -> ICU switch on Windows #21333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
commented
Nov 4, 2020
| @@ -0,0 +1,65 @@ | |||
| --- | |||
| title: Best practices for displaying and persisting formatted data in .NET | |||
There was a problem hiding this comment.
This file's content is not new - it was just split off from the uber best practices doc.
gewarren
commented
Nov 4, 2020
| title: "Best Practices for Using Strings in .NET" | ||
| description: Learn how to use strings effectively in .NET applications. | ||
| title: "Best Practices for Comparing Strings in .NET" | ||
| description: Learn how to compare strings effectively in .NET applications. |
There was a problem hiding this comment.
Since 95% of this file was about comparing strings, I think it's much clearer what it's about to say "best practices for comparing strings" rather than "best practices for using strings", which seems pretty vague to me.
BillWagner
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
This LGTM @gewarren
Thanks for the comments to aid the review. That helped quite a bit.
You can 
when ready.
|
Any more feedback before I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide whitespace changes in diff
Preview link.