-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore section that was deleted #22514
Conversation
docs/standard/serialization/system-text-json-ignore-properties.md
Outdated
Show resolved
Hide resolved
I wonder if this section was intentionally removed given that EDIT: I think I found the reason it was removed, see #21108 (comment). @layomia @eiriktsarpalis Could dotnet/runtime#40099 be a good reason to avoid obsoletion? |
Yes that's it, thanks. I'll leave this PR open until your question about obsoletion is resolved, but I'll change it back to draft. |
@jozkee hmm I don't think the edge case of avoiding I just don't like the idea of having two advertised ways of doing the same thing ( @tdykstra, what motivated opening this PR? Just want to be sure I'm not missing any info, otherwise, I say we close this PR. |
I'm fine with closing it. @jozkee asked me where the section went, and I forgot the story behind the deletion so I investigated, found it was removed in the 5.0 PR, thought I had removed it accidentally, and rushed (rather too quickly, it turns out) to put it back. |
Follow-up to #21108
Internal review URL