Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for disabling top-level imports #25232

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Add instructions for disabling top-level imports #25232

merged 2 commits into from
Aug 5, 2021

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Jul 20, 2021 •
edited
Loading

@kant2002 kant2002 requested a review from tdykstra as a code owner July 20, 2021 08:45
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 20, 2021
tdykstra
tdykstra requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this change! But I'd prefer to wait until #25250 is merged so we can link to msbuild-props.md#disableimplicitnamespaceimports.

@MichalStrehovsky MichalStrehovsky mentioned this pull request Aug 3, 2021
Closed
@RussKie
Copy link
Member

RussKie commented Aug 3, 2021

Related #25436

@BillWagner
Copy link
Member

ping @tdykstra It looks like #25250 has been merged. Should this be merged now?

@tdykstra
Copy link
Contributor

tdykstra commented Aug 5, 2021

Should this be merged now?

Yes, I added the link.

@tdykstra tdykstra self-requested a review August 5, 2021 16:34
@tdykstra tdykstra merged commit 91fdd0e into dotnet:main Aug 5, 2021
@kant2002 kant2002 deleted the patch-4 branch August 5, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.
5 participants
@kant2002 @RussKie @BillWagner @tdykstra @dotnet-bot