Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Drawing.Common breaking change #25367

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 27, 2021

Contributes to #25257

Preview link.

@BillWagner BillWagner removed this from the July 2021 milestone Aug 5, 2021
@gewarren gewarren marked this pull request as ready for review August 12, 2021 19:39
@gewarren gewarren requested review from safern and a team August 12, 2021 19:39
@gewarren
Copy link
Contributor Author

I'll go ahead and publish this, and once the migration examples are ready, I'll add those.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can update it to add code examples to have something published.


## New behavior

Starting in .NET 6, the platform analyzer emits compile-time warnings when referencing code is compiled for non-Windows operating systems. In addition, the following run-time exception is thrown unless you set a configuration option:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mention that in .NET 7 the plan is to no longer support this not even with the runtime config switch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs style guide says not to discuss future plans in documentation. @tdykstra @BillWagner How strictly do we adhere to this?

Copy link
Member

@safern safern Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The reason why I think in this case would be valuable, it is because we want to encourage customers to move off System.Drawing.Common for xplat and don't want this to be a surprise when we release 7.0.

@gewarren gewarren merged commit bf04e77 into dotnet:main Aug 16, 2021
@gewarren gewarren deleted the drawing-common branch August 16, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants