Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third category and WCF Client area #33001

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Add third category and WCF Client area #33001

merged 2 commits into from
Dec 14, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren requested a review from a team as a code owner December 14, 2022 00:20
@dotnet-bot dotnet-bot added this to the December 2022 milestone Dec 14, 2022
@PriyaPurkayastha
Copy link

Looks good to me. cc @marklio since behavioral change is added as a classification type and definitions have been slightly tweaked. cc @HongGit for area WCF Client addition.

@PriyaPurkayastha
Copy link

cc @mconnew

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Should we provide a link to https://learn.microsoft.com/dotnet/core/compatibility/categories in the description? E.g., as How do I decide?.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit f08dcf8 into main Dec 14, 2022
@gewarren gewarren deleted the gewarren-patch-2 branch December 14, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants