-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for Scope Mismatch issue for HttpClientFactory #34864
Merged
IEvangelist
merged 4 commits into
dotnet:main
from
CarnaViire:httpclientfactory-scope-workaround
Apr 20, 2023
Merged
Add workaround for Scope Mismatch issue for HttpClientFactory #34864
IEvangelist
merged 4 commits into
dotnet:main
from
CarnaViire:httpclientfactory-scope-workaround
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a few nits.
docs/core/extensions/snippets/http/scopeworkaround/AuthenticatingHandler.cs
Outdated
Show resolved
Hide resolved
IEvangelist
reviewed
Apr 4, 2023
docs/core/extensions/snippets/http/scopeworkaround/ScopeAwareHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
IEvangelist
reviewed
Apr 4, 2023
docs/core/extensions/snippets/http/scopeworkaround/ScopeAwareHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
IEvangelist
reviewed
Apr 4, 2023
docs/core/extensions/snippets/http/scopeworkaround/ScopeAwareHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
IEvangelist
reviewed
Apr 4, 2023
docs/core/extensions/snippets/http/scopeworkaround/ScopeAwareHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Pine <david.pine@microsoft.com>
PTAL @IEvangelist |
IEvangelist
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds workaround for accessing application DI scope for
HttpClientFactory
, as the Scope Mismatch issue dotnet/runtime#47091 most possibly won't be fixed in .NET 8.0.Based on workarounds suggested in the issue.
Contributes to dotnet/runtime#47091
Internal previews