Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for Scope Mismatch issue for HttpClientFactory #34864

Merged

Conversation

CarnaViire
Copy link
Member

@CarnaViire CarnaViire commented Apr 3, 2023

Summary

Adds workaround for accessing application DI scope for HttpClientFactory, as the Scope Mismatch issue dotnet/runtime#47091 most possibly won't be fixed in .NET 8.0.

Based on workarounds suggested in the issue.

Contributes to dotnet/runtime#47091


Internal previews

📄 File 🔗 Preview link
docs/core/extensions/httpclient-factory.md IHttpClientFactory with .NET

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a few nits.

docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
docs/core/extensions/httpclient-factory.md Outdated Show resolved Hide resolved
CarnaViire and others added 2 commits April 6, 2023 20:53
Co-authored-by: David Pine <david.pine@microsoft.com>
@CarnaViire CarnaViire requested a review from IEvangelist April 6, 2023 19:32
@CarnaViire
Copy link
Member Author

PTAL @IEvangelist

@IEvangelist IEvangelist merged commit df368a0 into dotnet:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants