Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F# - Add an example for formatting long secondary constructor #39096

Conversation

MangelMaxime
Copy link
Contributor

@MangelMaxime MangelMaxime commented Jan 11, 2024

Summary

Add an explicit example of how to format secondary constructors.

This PR is a follow up to an issue I opened on Fantomas (an F# formatter tool) and they asked to add an example to address any potential concerns from the community.

Edit: Added Fantomas issue link


Internal previews

📄 File 🔗 Preview link
docs/fsharp/style-guide/formatting.md F# code formatting guidelines

@dotnet-bot dotnet-bot added this to the January 2024 milestone Jan 11, 2024
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jan 11, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MangelMaxime

This LGTM, and I'll :shipit: now.

@vzarytovskii vzarytovskii merged commit 548fc33 into dotnet:main Jan 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants