[Diagnostics] Add EventSource Callback Possible Deadlock Warning #43197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
force-pushed
the
add_deadlock_warning_for_eventsource_callbacks
branch
from
1a73375 to
33cd37b
Compare
noahfalk
reviewed
Oct 24, 2024
noahfalk
approved these changes
Oct 29, 2024
|
@dotnet/docs Could I get a review for this change, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to improve EventSource documentation by warning users against bad practices when implementing EventSource callbacks.
Fixes dotnet/diagnostics#4825
Internal previews