Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for CppInlineNamespaceAttribute #4843

Closed
wants to merge 1 commit into from

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Introduced in: dotnet/runtime#781

@opbld30
Copy link

opbld30 commented Sep 14, 2020

Docs Build status updates of commit ae8c150:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/CppInlineNamespaceAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop
Copy link
Member

@MSDN-WhiteKnight thank you for your PR. It looks good to me.

We are temporarily merging .NET 5.0 changes into the net5-rc2 branch, not master. I talked to @Anipik, who is the main area owner of System.Runtime.CompilerServices, and he agreed to cherry-pick your change in this PR and include it in a bigger PR he is going to submit soon to the net5-rc2 branch, documenting everything new in that namespace.

Again, thank you for your contribution!

@carlossanlop
Copy link
Member

carlossanlop commented Sep 22, 2020

PR cherry-picking this change: #4902

Closing this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants