.NET 6 Preview 6 API updates #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=231897&view=results source_repo.branch:net6-preview6 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
333fred,
AaronRobinsonMSFT,
adamsitnik,
ajcvickers,
Anipik,
bartonjs,
buyaa-n,
carlossanlop,
cheenamalhotra,
cston,
David-Engel,
eiriktsarpalis,
GrabYourPitchforks,
halter73,
HongGit,
jkoritzinsky,
jkotalik,
joperezr,
jozkee,
kouvel,
krwq,
layomia,
maryamariyan,
merriemcgaw,
michaelgsharp,
pgovind,
RussKie,
safern and
StephenMolloy
as code owners
gewarren
requested review from
steveharter,
tannergooding,
tarekgh,
ViktorHofer and
a team
as code owners
| @@ -0,0 +1,285 @@ | |||
| <Type Name="AvxVnni" FullName="System.Runtime.Intrinsics.X86.AvxVnni"> | |||
There was a problem hiding this comment.
The types under here qualify for: #6861
If its possible, we should ensure the RequiresPreviewFeatures attribute is visible and that the page comes with some sort of disclaimer that the APIs are preview and are subject to change (including being removed) between now and the next release (up until the attribute is removed).
tannergooding
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
APIs covered by System.Buffers, System.Numerics, System.Runtime, System.Runtime.Intrinsics and System.Text.RegularExpressions LGTM.
I left a comment about the RequiresPreviewFeatures APIs, which we'll likely have more of for Preview 7.
CC. @pgovind for a second pair of eyes
|
Docs Build status updates of commit 1573e94:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.Url: https: //apidrop.visualstudio.com/Content%20CI/_build/results?buildId=231897&view=results
source_repo.branch: net6-preview6
source_repo.url: https://apidrop.visualstudio.com/_git/binaries