-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reflection metadata doc #8476
Conversation
Learn Build status updates of commit 86ba8bc: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Consider expanding what low-level means here. For example, SRM is different from other libraries in that it could throw unmanaged access violation exceptions when using APIs on MetadataReader referring to disposed PeReader, instead of ObjectDisposedException. Not sure it's worth mentioning in namespace remarks, but it is very annoying in desktop apps, because on AV the whole process just dies with very poor error diagnostics. |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Learn Build status updates of commit 7620aa9: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Summary
Addresses feedback from dotnet/runtime#76567 (comment). cc @jkotas, @jeffhandley
The reflection metadata doc is lacking and this PR helps, at least for the most common classes.