Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zlib-devel dependency from azurelinux for .NET 9.0 #1125

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Jul 3, 2024

Contributes to dotnet/runtime#101465

For .NET 9.0, we brought a copy of zlib-ng into dotnet/runtime that will be used by all platforms, except for the mobile ones (android, ios, tvos, maccatalyst) and armv6: dotnet/runtime#102403

For that reason, and as suggested in this comment, the azurelinux docker images that target .NET 9.0 won't need to install zlib-devel as a dependency anymore.

@jkotas jkotas added the do-not-merge A PR that should not be merged yet but needs to remain open label Jul 4, 2024
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait a few weeks for the dust to settle before merging.

@carlossanlop
Copy link
Member Author

We should wait a few weeks for the dust to settle before merging.

@jkotas How about I merge this on Monday August 12th? That's one day before we release P7. On the 13th we will start consuming P7 officially in our own repos.

@jkotas
Copy link
Member

jkotas commented Jul 20, 2024

That's one day before we release P7.

This is nice-to-have cleanup. I think that doing this one day after we release P7 would make more sense, so that it cannot interfere with P7 release in any way by construction.

@carlossanlop
Copy link
Member Author

carlossanlop commented Aug 15, 2024

P7 has already been released. We even snapped 9.0 already. So this should be safe to merge now.

@carlossanlop carlossanlop merged commit b90fbfe into dotnet:main Aug 15, 2024
21 checks passed
@carlossanlop carlossanlop deleted the removeZlib branch August 15, 2024 19:31
@carlossanlop carlossanlop removed the do-not-merge A PR that should not be merged yet but needs to remain open label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants