Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Install 7z in windows helix image #476

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

radekdoulik
Copy link
Member

Context: to reduce size in dotnet/runtime#54451
from cca 1.1GB to 220MB when using 7z instead of zip

Context: to reduce size in dotnet/runtime#54451
from cca 1.1GB to 220MB when using 7z instead of zip
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a license associated with 7-Zip that will need to be included due to the binary redistribution: https://www.7-zip.org/license.txt.

@radekdoulik
Copy link
Member Author

There's a license associated with 7-Zip that will need to be included due to the binary redistribution: https://www.7-zip.org/license.txt.

The installer puts the license in the destination dir.

C:\Work>dir \7z
 Volume in drive C has no label.
 Volume Serial Number is EC20-EEE0

 Directory of C:\7z

07/12/2021  09:48 PM    <DIR>          .
07/12/2021  09:48 PM    <DIR>          ..
02/20/2019  01:00 PM           108,074 7-zip.chm
02/21/2019  06:00 PM            78,336 7-zip.dll
02/21/2019  06:00 PM            50,688 7-zip32.dll
02/21/2019  06:00 PM         1,679,360 7z.dll
02/21/2019  06:00 PM           468,992 7z.exe
02/21/2019  06:00 PM           205,824 7z.sfx
02/21/2019  06:00 PM           186,880 7zCon.sfx
02/21/2019  06:00 PM           867,840 7zFM.exe
02/21/2019  06:00 PM           581,632 7zG.exe
01/28/2018  11:00 AM               366 descript.ion
02/22/2019  11:26 AM            48,844 History.txt
07/12/2021  09:48 PM    <DIR>          Lang
01/09/2019  12:15 PM             3,990 License.txt
02/22/2019  11:28 AM             1,688 readme.txt
02/21/2019  07:00 PM            15,360 Uninstall.exe
              14 File(s)      4,297,874 bytes
               3 Dir(s)  21,246,578,688 bytes free

Hopefully that should be fine then. Or should I download it explicitely?

@mthalman
Copy link
Member

Ah, that should be fine. I didn't look closely enough and just thought it was copying a CLI executable instead of an installer.

@radekdoulik radekdoulik merged commit 37436dd into dotnet:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants