Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate image for gcc 11 #504

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 10, 2021

GNU compiler toolchain is used in runtime for native build validation. The LLVM toolchain is default one to build the shipping product.

Currently we are using gcc9 from centos-7 image, which we install from YUM packages when building the prereq image for two purposes:

  1. to compile custom llvm toolchain
  2. to use it in for the said validation leg in runtime repo

Therefore, it is non-trivial to upgrade gcc independently, as first we need to wait fro devtoolset to pick up the GNU version, then we need to make sure our custom llvm toolchain's build is intact.

This PR adds gcc 11 leg based on official library layer (https://hub.docker.com/_/gcc), which uses Debian 11 (buillseye) for gcc 11. In future, we can add src/debian/{version}/gcc/Dockerfile when needed, without affecting anything else.

@am11
Copy link
Member Author

am11 commented Sep 10, 2021

cc @janvorli, @hoyosjs, @wfurt
I have tested it locally, will send a PR in runtime to switch gcc leg to this container once we have the new image produced.

@am11 am11 force-pushed the feature/gcc-11 branch 2 times, most recently from 526f6c0 to 6353e7c Compare September 10, 2021 06:09
@am11
Copy link
Member Author

am11 commented Sep 10, 2021

Failures are in unrelated legs (Ubuntu certificates are expired)

@am11
Copy link
Member Author

am11 commented Sep 11, 2021

Rebased with main.
Ubuntu error went away, since it was fixed by #505.
Speaking of moving targets, between yesterday and today, Fedora 34 regressed due to pip marked as optional dependency... opened #506 with the fix.

@am11
Copy link
Member Author

am11 commented Sep 13, 2021

All green. Lets snapshot it now before it regresses. 😅

@hoyosjs, @janvorli, this will potentially fix all 2565 warnings currently we are hitting in gcc leg, enable us to unsuppress -Wall in the JIT and hopefully will close dotnet/runtime#33541. Those warnings seem to be fixed in gcc 11.

@hoyosjs
Copy link
Member

hoyosjs commented Sep 13, 2021

LGTM if the runtime properly builds on this container. Thanks @am11!

@am11
Copy link
Member Author

am11 commented Sep 16, 2021

Thanks! @mthalman, if it LGTYT, please merge.

@mthalman mthalman merged commit f42d766 into dotnet:main Sep 16, 2021
@am11 am11 deleted the feature/gcc-11 branch September 16, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants