Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Release - 5.0 SDK #2830

Closed
23 of 30 tasks
mthalman opened this issue May 25, 2021 · 9 comments
Closed
23 of 30 tasks

.NET Release - 5.0 SDK #2830

mthalman opened this issue May 25, 2021 · 9 comments

Comments

@mthalman
Copy link
Member

mthalman commented May 25, 2021

.NET Release

Release Versions

The set of .NET versions that are being released as a unit.

  • 5.0.300

1. Main Branch Tasks

    • Merge appropriate commits from nightly branch. Things to check:
      • New/EOL distro
      • Infrastructure changes
      • PowerShell version
      • Check for additional changes by diffing the main and nightly branches
      • <add link to PR/commit>
    • Check whether a change has been made to a Dockerfile that is shared by multiple .NET versions. If a change has been made and the .NET versions that share that file are not being released at the same time, define a separate Dockerfile to isolate the change to the .NET version that's being released. Conversely, after a shared Dockerfile has diverged in such a way, it should be combined again into a shared Dockerfile when the other other .NET version is released. Shared Dockerfiles to check:
      • 3.1 runtime-deps shared with 5.0 and 6.0
    • Wait for .NET archive files (.zip, .tar.gz) to be available at blob storage location
    • Run update-dependencies tool to update all the necessary files to reflect the specified .NET versions (run this command for each version being released):
      • dotnet run --project .\eng\update-dependencies\update-dependencies.csproj 5.0 --product-version sdk=5.0.300
    • Inspect generated changes for correctness
    • Commit generated changes
    • Create PR
    • Get PR signoff
    • Merge PR
    • Build images - Queue build stage of dotnet-docker pipeline (internal MSFT link) with variables:

      All releases:

       stages: build
      

      Servicing release (exclude 5.0/6.0 if separate runtime-deps Dockerfiles were defined):

       noCache: true
       imageBuilder.pathArgs: --path 'src/*/3.1/*' --path 'src/*/5.0/*' --path 'src/*/6.0/*' --path 'src/monitor/*'
      
    • Wait for NuGet packages to be published during release tic-toc
    • Test and publish images - Queue build of dotnet-docker pipeline (internal MSFT link) with variables:

      All releases:

       stages: test;publish
       sourceBuildId: <Build ID from the build stage>
      

      Servicing release (exclude 5.0/6.0 if separate runtime-deps Dockerfiles were defined):

       imageBuilder.pathArgs: --path 'src/*/3.1/*' --path 'src/*/5.0/*' --path 'src/*/6.0/*' --path 'src/monitor/*'
      

2. Nightly Branch Tasks (Not needed for Preview-only release)

    • Merge main branch to nightly
    • Run the same update-dependencies command(s) in nightly that were run for the main branch
    • Inspect generated changes for correctness
    • Commit generated changes
    • Create PR
    • Get PR signoff
    • Merge PR
@Gladskih
Copy link

Gladskih commented May 26, 2021

And you have broken PAT authentication for AzureDevOps nuget feeds.
It was ok before like this:
RUN dotnet nuget add source ${feed_uri} --name ${feed_name} --username "whatever" --password=${PAT} --store-password-in-clear-text --valid-authentication-types "basic"
And now restore step get 403 Forbidden.

@KoenWillemse
Copy link

We're running into issue with the 5.0-focal docker image. All our builds used to work fine until the update of yesterday. We're running into issues with packing. We get following error now:

/usr/share/dotnet/sdk/5.0.300/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5050: Attempted to pack multiple files into the same location(s). The following destinations were used multiple times: ./api-ms-win-core-util-l1-1-0.dll, ./Microsoft.AspNetCore.DataProtection.Extensions.dll, ./api-ms-win-crt-math-l1-1-0.dll,

We were not experiencing any issues until today.

@melihc1
Copy link

melihc1 commented May 26, 2021

Can you provide a stable tag for images based on latest stable release versions?

https://github.com/dotnet/sdk/releases

@mthalman
Copy link
Member Author

While we investigate, you can use the 5.0.203 tag, which was the previous version, to become unblocked. You can see the list of current tags at https://hub.docker.com/_/microsoft-dotnet-sdk. By replacing 5.0.300 with 5.0.203, it'll give you the appropriate previous version.

@mthalman
Copy link
Member Author

We're running into issue with the 5.0-focal docker image. All our builds used to work fine until the update of yesterday. We're running into issues with packing. We get following error now:

/usr/share/dotnet/sdk/5.0.300/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5050: Attempted to pack multiple files into the same location(s). The following destinations were used multiple times: ./api-ms-win-core-util-l1-1-0.dll, ./Microsoft.AspNetCore.DataProtection.Extensions.dll, ./api-ms-win-crt-math-l1-1-0.dll,

We were not experiencing any issues until today.

@zkat - Can you comment on this? It looks related to NuGet/NuGet.Client#3923. Was this change introduced in .NET 5.0.300 SDK?

@mthalman
Copy link
Member Author

And you have broken PAT authentication for AzureDevOps nuget feeds.
It was ok before like this:
RUN dotnet nuget add source ${feed_uri} --name ${feed_name} --username "whatever" --password=${PAT} --store-password-in-clear-text --valid-authentication-types "basic"
And now restore step get 403 Forbidden.

@Gladskih - Unfortunately, I can't repro this. I tried with both Linux and Windows containers on 5.0.300 SDK and it worked when targeting a private Azure DevOps feed. Have you verified that reverting back to the previous version of the SDK resolves your issue (see #2830 (comment))? Please feel free to log a separate issue and provide more detail such as your Docker environment, Dockerfile, project file, etc.

@Gladskih
Copy link

Gladskih commented May 26, 2021

@mthalman Yes, I used exactly reverting last night to fix the build.

@zkat
Copy link

zkat commented May 26, 2021

Yes, we made a decision to let this change in: NuGet/Home#6941 (comment)

If you're running into this issue, you've been non-deterministically clobbering files during pack this whole time, which we consider to have been a bug.

@MichaelSimons
Copy link
Member

[Triage] Closing as the release is complete. If you have encountered any issues with the 5.0.300 sdk images, please open new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants