Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates for 5.0 repo name change #1905

Merged
merged 2 commits into from
May 12, 2020

Conversation

mthalman
Copy link
Member

Addresses the remaining review comments from #1888.

@@ -9,6 +9,8 @@ The images from the dotnet/nightly repositories include last-known-good (LKG) bu

See [dotnet/core](https://hub.docker.com/_/microsoft-dotnet-core/) for images with official releases of [.NET](https://github.com/dotnet/core).

As part of the transition to .NET 5.0, Docker repos for .NET 5.0 and higher do not include `core` in the name as was done with older versions. As an example, ASP.NET Core 5.0 can be found at `mcr.microsoft.com/dotnet/nightly/aspnet:5.0` while 3.1 is still at `mcr.microsoft.com/dotnet/core-nightly/aspnet:3.1`. See the [related issue](https://github.com/dotnet/dotnet-docker/issues/1765) for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once an announcement is made, it feels appropriate for update the issue link to reference it.

Copy link
Member Author

@mthalman mthalman May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this to my todo list. #1901

README.sdk.preview.md Outdated Show resolved Hide resolved
README.runtime.preview.md Outdated Show resolved Hide resolved
@mthalman mthalman mentioned this pull request May 12, 2020
28 tasks
@mthalman mthalman merged commit 43fd1ed into dotnet:nightly May 12, 2020
@mthalman mthalman deleted the readme-updates branch May 12, 2020 15:28
mthalman added a commit to mthalman/dotnet-docker that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants