Create tests that verifies the Dockerfiles and templates are in sync #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
force-pushed
the
template-tests
branch
16 times, most recently
from
307753d to
b905b8f
Compare
MichaelSimons
force-pushed
the
template-tests
branch
from
b905b8f to
3c4653d
Compare
MichaelSimons
commented
Jul 22, 2020
| } | ||
|
|
||
| & $PSScriptRoot/../common/Invoke-ImageBuilder.ps1 ` | ||
| -ImageBuilderArgs "generateDockerfiles --architecture * --os-type *$pathArgs" ` | ||
| -ImageBuilderArgs "generateDockerfiles --architecture '*' --os-type '*'$customImageBuilderArgs" ` |
There was a problem hiding this comment.
The quoted asterisks are required when running in a linux environment.
MichaelSimons
commented
Jul 22, 2020
| @@ -18,13 +18,6 @@ | |||
| <Content Include="TestAppArtifacts/*"> | |||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |||
| </Content> | |||
| <Content Include="../../manifest.json"> | |||
There was a problem hiding this comment.
Continuing this pattern didn't seem like a good choice as we would need to copy pretty much the entire repo as content in order to validate the Dockerfile templates. Instead an ENV is now used to specify the source repo directory.
mthalman
approved these changes
Jul 22, 2020
…o template-tests
MichaelSimons
added a commit
to MichaelSimons/dotnet-docker
that referenced
this pull request
Jul 23, 2020
MichaelSimons
added a commit
to MichaelSimons/dotnet-docker
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1933
These changes introduce a pre-build validation step in the builds. This works nicely for validating the templates and Dockerfiles are in-sync. It will also provide a nice place to validate the readme tag listing is up-to-date as well. I will back port the common eng infrastructure changes to docker-tools once merged.