-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md with workflow instructions #2118
Update CONTRIBUTING.md with workflow instructions #2118
Conversation
.github/CONTRIBUTING.md
Outdated
@@ -1,4 +1,63 @@ | |||
Contributing | |||
============ | |||
# Contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mthalman - thoughts on moving this to the root of the repo to give it more visibility? I suggest this because the repo's README.md doesn't reference it like most repos do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean like adding a section like this that links to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not proposing any changes to the READMEs. I don't think the contribution guide should be mentioned in the Docker Hub readmes. I am simply suggesting we move CONTRIBUTING.md to the root of the repo to give it more visibility. The CONTRIBUTING.md file can be located at either the root or within the .github folder. FWIW, the file is located at the root of https://github.com/dotnet/runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think moving the file is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting there to be some information about invoking update-dependencies as well.
.github/CONTRIBUTING.md
Outdated
@@ -1,4 +1,63 @@ | |||
Contributing | |||
============ | |||
# Contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean like adding a section like this that links to this file?
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
2a3528b
to
a368acb
Compare
@mthalman - can you please take a look at the |
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
related to #1933 and #514