Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with workflow instructions #2118

Merged
merged 10 commits into from
Jul 23, 2020

Conversation

MichaelSimons
Copy link
Member

related to #1933 and #514

@MichaelSimons MichaelSimons requested a review from mthalman July 22, 2020 16:15
@@ -1,4 +1,63 @@
Contributing
============
# Contributing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthalman - thoughts on moving this to the root of the repo to give it more visibility? I suggest this because the repo's README.md doesn't reference it like most repos do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like adding a section like this that links to this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not proposing any changes to the READMEs. I don't think the contribution guide should be mentioned in the Docker Hub readmes. I am simply suggesting we move CONTRIBUTING.md to the root of the repo to give it more visibility. The CONTRIBUTING.md file can be located at either the root or within the .github folder. FWIW, the file is located at the root of https://github.com/dotnet/runtime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think moving the file is a good idea.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting there to be some information about invoking update-dependencies as well.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@@ -1,4 +1,63 @@
Contributing
============
# Contributing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like adding a section like this that links to this file?

MichaelSimons and others added 4 commits July 22, 2020 16:03
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
@MichaelSimons
Copy link
Member Author

@mthalman - can you please take a look at the Updating Product Versions section I added?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
MichaelSimons and others added 3 commits July 23, 2020 08:55
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
@MichaelSimons MichaelSimons merged commit a1c4524 into dotnet:nightly Jul 23, 2020
@MichaelSimons MichaelSimons deleted the contribution-guide branch July 23, 2020 13:58
MichaelSimons added a commit to MichaelSimons/dotnet-docker that referenced this pull request Jul 23, 2020
MichaelSimons added a commit to MichaelSimons/dotnet-docker that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants