Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add procps package to Debian-based SDK images #2402

Closed

Conversation

elafarge
Copy link

This package is now required for "dotnet watch" to actually watch for
file changes on Debian based images.

NOTE: with this patch we're installing the package on Ubuntu
based-distributions as well, as a (undesired?) side-effect.

The alternative would be to use Cottle templating language to only add
this patch for debian-based images.
The problem is their name varies accross versions (buster, bullseye...)
this would have made this bugfix less change-resistant.

Caused by: #2376

Github issue: #2396

This package is now required for "dotnet watch" to actually watch for
file changes on Debian based images.

NOTE: with this patch we're installing the package on Ubuntu
based-distributions as well, as a (undesired?) side-effect.

The alternative would be to use Cottle templating language to only add
this patch for debian-based images.
The problem is their name varies accross versions (buster, bullseye...)
this would have made this bugfix less change-resistant.

Caused by: dotnet#2376

Github issue: dotnet#2396
@dnfadmin
Copy link

dnfadmin commented Nov 18, 2020

CLA assistant check
All CLA requirements met.

@MichaelSimons
Copy link
Member

@elafarge, Thanks for your willingness to help out here. Per the discussion in #2396, we are going remove this dependency from dotnet-watch therefore no changes are needed to the SDK images. dotnet/aspnetcore#27950 is tracking this work.

@elafarge elafarge deleted the fix-dotnet-watch-in-debian-sdk-image branch November 18, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants