Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presence check for procps on Debian-based images #2403

Conversation

elafarge
Copy link

On Debian-based distributions, the procps package is required for
the "dotnet watch" command to work accordingly.

This has introduced a regression in the official sdk:5.0 image
recently.

This commit adds a test that ensures this package is present on
Debian-based distribution (we're assuming an image is Debian based
if the "dpkg" command is present).

Issue: #2396

On Debian-based distributions, the procps package is required for
the "dotnet watch" command to work accordingly.

This has introduced a regression in the official sdk:5.0 image
recently.

This commit adds a test that ensures this package is present on
Debian-based distribution (we're assuming an image is Debian based
if the "dpkg" command is present).

Issue: dotnet#2396
@elafarge
Copy link
Author

I didn't expect any impact on the ARM64 Alpine build (it seems that it has dpkg installed on it, maybe I'll rely on something else to figure out which OS I'm running on). Will work on that in a few hours.

@MichaelSimons
Copy link
Member

@elafarge, Thanks for your willingness to help out here. Per the discussion in #2396, we are going remove this dependency from dotnet-watch therefore no changes are needed to the SDK images. dotnet/aspnetcore#27950 is tracking this work.

@elafarge elafarge deleted the add-procps-presence-check-on-debian-based-sdk-image branch November 18, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants