Update Dockerfiles for 7.0.200 and remove PublishSingleFile
#4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richlander
requested review from
MichaelSimons,
mthalman and
lbussell
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mthalman
reviewed
Mar 31, 2023
There was a problem hiding this comment.
This only applies the change to the published aspnet sample. Anyone building any of the other sample slim Dockerfiles will run into the same issue this is intended to address. Shouldn't it be applied across the board for all slim Dockerfiles for both aspnetapp and dotnetapp?
|
That's a good point. I can do that. |
richlander
changed the title
PublishSingleFile
mthalman
reviewed
Apr 3, 2023
samples/README.md
Outdated
Comment on lines
27
to
28
| * [Push container Images to Azure Container Registry](push-image-to-acr.md) | ||
| * [Push container Images to Docker Hub](push-image-to-dockerhub.md) |
MichaelSimons
approved these changes
Apr 3, 2023
mthalman
reviewed
Apr 3, 2023
| { | ||
| if (imageData.DockerfileSuffix == "windowsservercore-iis-x64") |
There was a problem hiding this comment.
This shouldn't be deleted. Rather, it should be updated to reflect the new filenames (i.e. windowsservercore-iis).
mthalman
approved these changes
Apr 4, 2023
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the opportunity to clean up our Dockerfiles, including applying the
PublishReleasefeature (new in 7.0.200).Replaces (most of): #4441
For: #4271