Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to prune processes during tracing #1103

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Do not attempt to prune processes during tracing #1103

merged 2 commits into from
Nov 15, 2021

Conversation

wiktork
Copy link
Member

@wiktork wiktork commented Nov 4, 2021 •
edited
Loading

It appears that the event pipe is not responsive during rundown, which causes our pruning mechanism to remove processes (similar to dumps). Possibly related to dotnet/runtime#1892.

  • The pruning algorithm should probably do multiple attempts over a period of time to see if the process is really to be removed.
  • The real fix should make rundown more configurable. We are defaulting to true in some cases we may not need.
  • There may be other affected artifacts (gcdump/logs).
  • We should converge the OperationTrackerService and the RequestLimitTracker at some point.

@wiktork wiktork requested a review from a team as a code owner November 4, 2021 07:08
@wiktork wiktork changed the title Do not attempt to prune services during tracing Do not attempt to prune processes during tracing Nov 4, 2021
@wiktork wiktork marked this pull request as draft November 4, 2021 07:08
@wiktork wiktork marked this pull request as ready for review November 4, 2021 17:18
@wiktork wiktork linked an issue Nov 4, 2021 that may be closed by this pull request
CollectTrace with rundown in Listen mode prunes the active process #1106
Closed
@wiktork wiktork force-pushed the dev/wiktork/fixRundownDisconnect branch from 67196c6 to c8dd77a Compare November 6, 2021 04:10
@wiktork wiktork merged commit 7466ba4 into dotnet:release/6.0 Nov 15, 2021
wiktork added a commit to wiktork/dotnet-monitor that referenced this pull request Nov 15, 2021
@wiktork
Do not attempt to prune processes during tracing (dotnet#1103)
0947f23 
* Do not attempt to prune services during tracing

* PR Feedback + Log message for timeout
wiktork added a commit that referenced this pull request Nov 16, 2021
@wiktork
Do not attempt to prune processes during tracing (#1103) (#1142)
5d0ae25 
* Do not attempt to prune services during tracing

* PR Feedback + Log message for timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkeirstead kkeirstead kkeirstead left review comments

@jander-msft jander-msft jander-msft approved these changes

@kelltrick kelltrick Awaiting requested review from kelltrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CollectTrace with rundown in Listen mode prunes the active process
3 participants
@wiktork @jander-msft @kkeirstead