Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using runtime id for profiler communication channel #1870

Merged
merged 10 commits into from
May 31, 2022
Merged

Enable using runtime id for profiler communication channel #1870

merged 10 commits into from
May 31, 2022

Conversation

wiktork
Copy link
Member

@wiktork wiktork commented May 9, 2022

E.g:

 "Actions": [
                {
                    "Type": "SetEnvironmentVariable",
                    "Settings": {
                        "Name": "DotnetMonitorProfiler_InstanceId",
                        "Value": "$(ProcessInfo.InstanceId)"
                    }
                },

@wiktork wiktork requested a review from a team as a code owner May 9, 2022 18:20
@jander-msft jander-msft added the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label May 10, 2022
@wiktork wiktork requested a review from IEvangelist as a code owner May 10, 2022 17:55
@wiktork wiktork force-pushed the dev/wiktork/ipcCleanup branch 2 times, most recently from 4691930 to 367b005 Compare May 10, 2022 21:17
jander-msft
jander-msft requested changes May 12, 2022
View reviewed changes
src/MonitorProfiler/Logging/NullLogger.cpp Outdated Show resolved Hide resolved
src/MonitorProfiler/MainProfiler/MainProfiler.cpp Outdated Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Outdated Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Outdated Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Outdated Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Outdated Show resolved Hide resolved
src/Tools/dotnet-monitor/CollectionRules/ActionOptionsDependencyAnalyzer.cs Outdated Show resolved Hide resolved
@wiktork wiktork force-pushed the dev/wiktork/ipcCleanup branch from 367b005 to 3b00a3e Compare May 18, 2022 23:45
@wiktork wiktork requested a review from jander-msft May 18, 2022 23:46
@wiktork wiktork mentioned this pull request May 25, 2022
Closed
@wiktork wiktork requested a review from jander-msft May 26, 2022 20:29
@wiktork wiktork merged commit 0c07564 into dotnet:release/6.x May 31, 2022
@wiktork
Copy link
Member Author

wiktork commented May 31, 2022

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/dotnet-monitor/actions/runs/2416475924

@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
@jander-msft jander-msft removed the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktork @jander-msft