Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Linux dump tests and OS X Mach-O verification #321

Merged
merged 3 commits into from
May 18, 2021
Merged

Enable Linux dump tests and OS X Mach-O verification #321

merged 3 commits into from
May 18, 2021

Conversation

jander-msft
Copy link
Member

@jander-msft jander-msft commented May 17, 2021 •
edited
Loading

These changes:

  • Enable Linux dump testing. Required parsing ELFHeaderIdent header to determine bitness and endianness before adding ELF parsing types for the full ELFHeader header.
  • Enable Mach-O dump testing for .NET 6+ on OS X.

closes #228
closes #322

@jander-msft jander-msft marked this pull request as ready for review May 18, 2021 00:36
@jander-msft jander-msft requested a review from a team as a code owner May 18, 2021 00:36
@jander-msft jander-msft added this to the Preview 5 milestone May 18, 2021
@jander-msft jander-msft added the testing Test work item label May 18, 2021
@jander-msft jander-msft self-assigned this May 18, 2021
@jander-msft
Enable Mach-O dump header verification for .NET 6
1fa11b7 
Increase dump timeout.
Fix RuntimeVersion parsing.
@jander-msft jander-msft changed the title Enable dump tests on Linux. Enable Linux dump tests and OS X Mach-O verification May 18, 2021
@jander-msft jander-msft merged commit 2a67347 into dotnet:main May 18, 2021
@jander-msft jander-msft deleted the dev/jander/dump-tests-linux branch May 18, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktork wiktork wiktork approved these changes

Assignees

@jander-msft jander-msft

Labels
testing Test work item
Projects
None yet
Milestone
Preview 5
Development

Successfully merging this pull request may close these issues.

Update DumpTests to output Mach-O format on OS X .NET6+ Re-enable DumpTest on Linux
2 participants
@jander-msft @wiktork