-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parameter Capturing] Support sending messages to managed in-proc features from dotnet-monitor #4775
Merged
schmittjoseph
merged 29 commits into
dotnet:feature/parameter-capturing
from
schmittjoseph:parameter-capturing/profiler-channel-trimmed
Jul 12, 2023
Merged
[Parameter Capturing] Support sending messages to managed in-proc features from dotnet-monitor #4775
schmittjoseph
merged 29 commits into
dotnet:feature/parameter-capturing
from
schmittjoseph:parameter-capturing/profiler-channel-trimmed
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-review
label
Jun 28, 2023
schmittjoseph
changed the title
[draft] [Parameter Capturing] Support sending messages to managed in-proc features from dotnet-monitor
[Parameter Capturing] Support sending messages to managed in-proc features from dotnet-monitor
Jun 28, 2023
jander-msft
reviewed
Jun 29, 2023
ghost
removed
the
needs-review
label
Jun 29, 2023
ghost
added
the
needs-review
label
Jun 29, 2023
wiktork
reviewed
Jun 29, 2023
...crosoft.Diagnostics.Monitoring.StartupHook/MonitorMessageDispatcher/IMonitorMessageSource.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
needs-review
label
Jun 29, 2023
wiktork
reviewed
Jun 29, 2023
ghost
added
the
needs-review
label
Jun 30, 2023
ghost
removed
the
needs-review
label
Jun 30, 2023
jander-msft
reviewed
Jun 30, 2023
...crosoft.Diagnostics.Monitoring.StartupHook/MonitorMessageDispatcher/IMonitorMessageSource.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-review
label
Jun 30, 2023
jander-msft
reviewed
Jun 30, 2023
ghost
removed
the
needs-review
label
Jun 30, 2023
wiktork
reviewed
Jul 7, 2023
schmittjoseph
commented
Jul 7, 2023
ghost
added
the
needs-review
label
Jul 7, 2023
wiktork
reviewed
Jul 12, 2023
ghost
removed
the
needs-review
label
Jul 12, 2023
wiktork
previously approved these changes
Jul 12, 2023
ghost
added
the
needs-review
label
Jul 12, 2023
schmittjoseph
commented
Jul 12, 2023
wiktork
approved these changes
Jul 12, 2023
ghost
removed
the
needs-review
label
Jul 12, 2023
schmittjoseph
merged commit Jul 12, 2023
655ad56
into
dotnet:feature/parameter-capturing
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new infrastructure to support sending messages (with arbitrary managed object payloads) from
dotnet-monitor
to our in-process features either in theStartupHook
or theHostingStartup
assemblies.Overview:
System.Text.Json
.Example flow of sending a managed->managed message:
MonitorMessageDispatcher
for a given command and its payload object type.Out of scope of this PR:
INT32_MAX
.Release Notes Entry