[Parameter Capturing] Add support for generics, tuples, and nullable value types #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not confirmed whether functional test works yet.
…tead/typespec-param-support
schmittjoseph
added
experimental-feature
ghost
added
the
schmittjoseph
commented
Jan 10, 2024
...osoft.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/ProfilerAbi.cs
Show resolved
Hide resolved
wiktork
reviewed
Jan 12, 2024
...rosoft.Diagnostics.Monitoring.UnitTestApp/Scenarios/FunctionProbes/FunctionProbesScenario.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Jan 18, 2024
...rosoft.Diagnostics.Monitoring.UnitTestApp/Scenarios/FunctionProbes/FunctionProbesScenario.cs
Show resolved
Hide resolved
wiktork
approved these changes
Jan 18, 2024
schmittjoseph
deleted the
dev/joschmit+kkeirstead/typespec-param-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR was co-developed with @kkeirstead .
This PR adds support for generics, tuples, and nullable value types. All of these parameters are considered TypeSpecs. To support boxing them we need to identify their signature blobs and then get a metadata token that represents it.
We can leverage our managed signature decoder to find the signature blobs for these parameters and then let the mutating profiler convert these information into a metadata token (sometimes the profiler will need to produce a new token if there already isn't one for the given TypeSpec).
Release Notes Entry
Support capturing the following parameter types: generics, tuples, and nullable value types