ParameterCapturing: Remove quotes from string evaluations, include failure reason information make the value nullable #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilure reason information and IsNull flag
...ameterCapturing/ObjectFormatting/Formatters/DebuggerDisplay/DebuggerDisplayFormatterTests.cs
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2024
...ngStartup/ParameterCapturing/ObjectFormatting/Formatters/DebuggerDisplay/ExpressionBinder.cs
Outdated
Show resolved
Hide resolved
…trings and remove IsNull
clguiman
changed the title
...Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ObjectFormatting/ObjectFormatter.cs
Outdated
Show resolved
Hide resolved
src/Tools/dotnet-monitor/ParameterCapturing/ParameterCapturingEvents.cs
Outdated
Show resolved
Hide resolved
...Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ObjectFormatting/ObjectFormatter.cs
Outdated
Show resolved
Hide resolved
- Remove ObjectFormatterResult.Empty - Rename ParameterEvaluationFlags to ParameterEvaluationResult and convert it from an enum of flags to mutually exclusive enum values. - Update ObjectFormatter to default EvalResult to Success.
schmittjoseph
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ObjectFormatterResultwhich includes the evaluated and formatted parameter value and evaluation metadata flags (IsNull,FailedEval,UnsupportedEval,EvalHasSideEffects). `ObjectFormatter now returns objects of the new type.EventSourceEmittingProbes.EnterProbedoesn't request adding quotes to the formatted value anymore. The quotes were added to easily parse the ILogger output, but we don't have that problem anymore.ParameterCapturingEventSourceto send the new evaluation flags as part of the captured paramater.WebApi.Models.CapturedParameterto include a new optional property:EvalFailReason.Release Notes Entry