[Nullable Context] Standardize optional arrays in schema #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
force-pushed
the
nullability/fix-schema
branch
from
79fb7b9
to
ac3b6b8
Compare
jander-msft
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have nullable contexts enabled for our schema, we can fix an issue where we were reporting optional lists could be set as a null.
This PR standardizes all of our optional Lists to default to an empty collection and not be nullable and also have setters (we rely on these setters quite a bit in our tests).
Partial fix for #6929
Additional ref: https://github.com/dotnet/dotnet-monitor/pull/6932/files#r1663237955
Release Notes Entry