Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions again #5

Merged
merged 14 commits into from
Nov 2, 2023
Merged

update versions again #5

merged 14 commits into from
Nov 2, 2023

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Oct 31, 2023

this time past the stable versioning of runtime parts.

@danmoseley danmoseley marked this pull request as ready for review October 31, 2023 23:09
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@danmoseley danmoseley marked this pull request as draft November 1, 2023 01:53
@danmoseley
Copy link
Member Author

Let's get everything working before merging ...

@DamianEdwards
Copy link
Member

Update global.json to match

@danmoseley danmoseley marked this pull request as ready for review November 1, 2023 03:11
@danmoseley
Copy link
Member Author

OK works for me on Windows and Linux.

I had to use a lot of asterisks in the nuget.config just to get us through to .NET 8 GA -- there are so many packages of various versions in various different feeds it really isn't worth trying to lock down here which come from where. I gave up. It should be simple at .NET 8 GA

@danmoseley
Copy link
Member Author

Looks like @captainsafia changed Aspire to preview.2 -- I assume this was temporary to get the Mac temp path fix until we figure out why preview.1 aspire bits are no longer being pushed to the feeds.

@captainsafia
Copy link
Member

Looks like @captainsafia changed Aspire to preview.2 -- I assume this was temporary to get the Mac temp path fix until we figure out why preview.1 aspire bits are no longer being pushed to the feeds.

Correct! I suppose we'll want to target preview.1 in this repo once Aspire goes live.

@danmoseley
Copy link
Member Author

if this works for you too @captainsafia shall we merge?

@adityamandaleeka
Copy link
Member

It works for me too @danmoseley. Thanks!

@davidfowl
Copy link
Member

We should be downgrading the aspire version to preview1.

@danmoseley
Copy link
Member Author

We should be downgrading the aspire version to preview1.

Right, see my comment above, we need the mac fix. @captainsafia did you resolve the issue of not getting the updated preview 1 bit ons the feed?

@danmoseley
Copy link
Member Author

@joperezr 8.0.0-preview.1.23530.4 is still the latest Aspire.Hosting preview1 on https://pkgs.dev.azure.com/dnceng/internal/_packaging/dotnet-tools-internal/nuget/v3/index.json. This is blocking eshop picking up the .net conf Aspire.

@danmoseley
Copy link
Member Author

OK we found the aspire preview 1 bits are now in yet another feed. Added that and moved back to preview 1. Should be good to go now.

@danmoseley
Copy link
Member Author

@adityamandaleeka do you want to sign off / merge?

@joperezr
Copy link
Member

joperezr commented Nov 1, 2023

@joperezr 8.0.0-preview.1.23530.4 is still the latest Aspire.Hosting preview1 on https://pkgs.dev.azure.com/dnceng/internal/_packaging/dotnet-tools-internal/nuget/v3/index.json. This is blocking eshop picking up the .net conf Aspire.

Sorry for the confusion. Builds were being produced but not pushed to the feed because we were adding new channels that were specific to Aspire so that repos (like eshop) can take dependencies using dependency flow. We just merged this change dotnet/arcade#14184 (review) into arcade which adds support for those new channels and once that is ingested it will make it so builds resume getting pushed. For now, Let me know if you need a new build pushed to a feed and I can manually promote it

@adityamandaleeka adityamandaleeka merged commit 37f1216 into main Nov 2, 2023
1 check passed
@adityamandaleeka adityamandaleeka deleted the versions2 branch November 2, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants