fix for broken NuGet package #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jun 16, 2024
|
I have confirmed locally that this change broke the package (and that this fix produces a valid package) |
|
@ErikEJ Please rebase on |
|
@AndriySvyryd How do I do that from my branch? (Excuse my ignorance) - with git cli |
|
Something like |
|
@AndriySvyryd That di not go so well - let me start over |
|
got bit too by the previous NuGet package (wasn't removing old entries from files and was also creating some configuration subfolders), had to rollback via version control and install the new one which works fine (upgrading to new package wasn't solving the mess). Maybe rolling back to previous NuGet package might have worked too, but not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2262
@AndriySvyryd FYI 😭